Azure Jane Lunatic (Azz) 🌺 (![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png)
azurelunatic) wrote2010-06-21 02:32 pm
azurelunatic) wrote2010-06-21 02:32 pm
Entry tags:
code tour in progress
Because i r productive, I've both the need of a nap zomgnow, and a code tour in progress. This is just so that if D needs it ZOMGNOW-er than I wake up, this is the bit that I've already done. [edit: done with nap, got a couple more done, I may even finish this.]
This week's code tour is sponsored by that container of M&Ms with chocolate covered espresso beans mixed unexpectedly into it.
http://bugs.dwscoalition.org/buglist.cgi?chfieldto=Now&query_format=advanced&chfield=bug_status&chfieldfrom=2010-06-15&bug_status=RESOLVED&resolution=FIXED
(some of the bugs listed there are also covered in last week's, been checking and removing)
This week's code tour is sponsored by that container of M&Ms with chocolate covered espresso beans mixed unexpectedly into it.
11:17 AM 6/21/2010
Bug 2086: Latest Things by tag duplicates entries if more than one tag is used
Category: Misc UI/Frontend, Latest Things, tags
Patch by:fu
Description:zarhooie explains: "If an entry is tagged nanowrimo or nnwm09, it will show up in the Latest Things by tag feed: http://www.dreamwidth.org/latest?feed=nnwm09
However, if an entry is tagged both nanowrimo AND nnwm09, it will show up twice."
Bug 2660: re-sync CLAs with list
Category: Bugzilla, administrative details
Headbanging by:![[staff profile]](https://www.dreamwidth.org/img/silk/identity/user_staff.png)
denise
Description: Dreamwidth is a Free/Libre Open Source Software project, and uses contributions from its users. In order to keep things aboveboard and sane, Dreamwidth keeps a Contributor License Agreement on file for everybody who contributes in a way that goes into the open source project. If you're thinking "Hey, wait, everyone who's had a patch accepted has to send/fax/email in a signed statement saying it's OK to put that patch into the FLOSS project? Isn't that a lot of people? Sounds like an administrative nightmare to keep track of!" then you're bang on the nose. This is one of those things that onlydenise (or possibly her wife) can do, because she's the one who gets sent the physical paperwork. It has to be re-done every now and then, because more people show up and send in their paperwork.
Bug 356: Resubscribing to an inactive subscription results in multiple subscriptions
Category: APIs (RPC, XML, Flat), subscriptions, making things work
Patch by:kareila
Description: This is a stupid hairy bug, and I remember having someone (possiblyaveleh, or maybe fu) explain it to me in increasingly smaller words when it was causing problems on LiveJournal.
Here's the setup: You subscribe to something (say to new comments on a particular entry that's got a good discussion going). Then you decide you don't want to get notified of this anymore (maybe you're going on vacation and people are chatty), so you unsubscribe. The subscription is not deleted, but inactive. So far, so good. But maybe something makes you want to re-subscribe (you come back from vacation, read the backlog, and prepare for the inbox torrent), and you do so.
Instead of doing the smart thing, finding the existing inactive subscription, and reactivating it, it was creating a second subscription, and then getting massively confused and not allowing edits to the subscription (say you wanted to stop the torrent of emails but still get notification in your inbox). (If you subscribed again, it would create a third duplicate subscription, and so on.) You'd have to completely delete the subscription (of course, it wouldn't allow you to just delete one copy, it hosed all of them) and subscribe again to be able to make it work.
This fixes that: once this goes live the proliferating duplicate uneditable subscriptions will be a thing of the past.
Bug 1958: Remove ToS agreement code
Category: Misc UI/Frontend, making things simpler, fetch the code-machetes
Patch by:kareila, with initial work by denise.
Description: While in theory the ability to make all users agree to the changed Terms of Service every time someone updates it would be useful to some site out there, we don't use it, we don't need it, and out it goes!
Bug 2048: new mood theme: Sina'i Enantia's Dreamy Ds
Category: Misc UI/Frontend, mood themes
Patch by:kareila
Description: New mood theme incoming: "Sina'i Enantia's Dreamy Ds", consisting of the stylized 'd' from Dreamwidth's logo, filled in with different colors, patterns, and shadow colors to creatively interpet the various moods, including (perhaps my favorite) a simple black line outline in the shape of the 'd' for the 'blank' mood, and lavender with bright yellow lines crossing, reminiscent of asterisks or fireworks, for 'excited'.
Bug 2659: fix skipped modules in t/00-compile.t
Category: Misc Backend, making testing work properly
Patch by:kareila
Description: There were a bunch of things that were skipped in this particular test. This will make things work better and more completely.
Bug 2714: rename userinfo.bml to profile.bml
Category: Misc Backend, updating stuff
Patch by:ninetydegrees
Description: We don't call it the userinfo anymore, and actually neither does LiveJournal. This primarily helps new, lost developers looking for the file that builds the profile so they can make changes to it. Who'd think to search for "userinfo" if you want to work with "profile"?
Bug 1227: Crossposter fails when cut text attribute contains certain HTML entities
Category: Crossposter, WTF encoding, simple pictures are best
Patch by:allen, troubleshooting in comments from fu, mark, and jld
Description: Crossposts with various entities in the cut text were failing. There were various forms of trying to figure out how it broke and how best to fix it beforeallen declared: "Hey, here's an idea: instead of screwing around with re-encoding the decoded attributes from the parser, and trying to figure out exactly how the decoded – differs from a literal –, how about if we just tell the parser NOT TO
DECODE THEM IN THE FIRST PLACE? *sigh*" Best idea ever! Very glad to have you developing for us, sir.
Bug 5: Add "current mood of service" toy
Category: silly fun stuff
Patch by:exor674
Description: A silly/fun thing harking back to an old LiveJournal office toy: this takes the moods of recent entries from the Latest Things, ranks them on happy to sad, and displays the averaged mood of the service on the site map and Latest Things page.
Bug 103: Refactor default email change actions
Category: Misc Backend, user email address handling
Patch by:kareila
Description: Code for Doing Stuff when someone changed their email address was all over the place, repeated several different times on the back end. It's good to have stuff like this in only one place, so that when stuff changes, it either breaks or it doesn't (rather than one of them breaking and the rest not). Other stuff had started in this direction, and this finishes it.
Bug 1525: privilege function cleanup
Category: Misc Backend, privs
Patch by:kareila
Description: FILL IN
Bug 2522: community archive display not updating when alternate posting method used
Category: Misc Backend
Patch by:kareila
Description: FILL IN
Bug 2644: User.pm function to count accounts
Category: Misc Backend
Patch by:kareila
Description: FILL IN
Bug 2651: remove LJ::get_bio
Category: Misc Backend
Patch by:kareila
Description: FILL IN
Bug 2652: Allow LJ::Talk::Post::init to work outside web context
Category: Journal contents
Patch by:kareila
Description: FILL IN
Bug 2664: remove LJ::can_manage and LJ::can_manage_other
Category: Misc Backend
Patch by:kareila
Description: FILL IN
Bug 2693: LJ::Talk::js_quote_button
Category: Misc Backend
Patch by:kareila
Description: FILL IN
Bug 2700: remove LJ::nodb
Category: Misc Backend
Patch by:kareila
Description: FILL IN
Bug 715: distinguished collapsed comments from screened/deleted/suspended comments
Category: Style System
Patch by:ninetydegrees
Description: FILL IN
Bug 2500: Update Funky Circles to use latest CSS3 properties
Category: Style System
Patch by:ninetydegrees
Description: FILL IN
Bug 2720: /latest?feed=... doesn't work, if the tag_map doesn't contain the group name/feed name
Category: Misc UI/Frontend
Patch by:fu
Description: FILL IN
Bug 2728: Declaration of which themes are default/should go in the base category, is duplicated
Category: Style System
Patch by:fu
Description: FILL IN
Bug 2729: Error when loading a journal page which has a list of tags (dev environment only)
Category: Tags
Patch by:fu
Description: FILL IN
Bug 2730: Using quick reply from a thread in custom comments pages does not return you to thread view
Category: Journal contents
Patch by:fu
Description: FILL IN
This week's code tour is sponsored by that container of M&Ms with chocolate covered espresso beans mixed unexpectedly into it.
http://bugs.dwscoalition.org/buglist.cgi?chfieldto=Now&query_format=advanced&chfield=bug_status&chfieldfrom=2010-06-15&bug_status=RESOLVED&resolution=FIXED
(some of the bugs listed there are also covered in last week's, been checking and removing)
This week's code tour is sponsored by that container of M&Ms with chocolate covered espresso beans mixed unexpectedly into it.
11:17 AM 6/21/2010
Bug 2086: Latest Things by tag duplicates entries if more than one tag is used
Category: Misc UI/Frontend, Latest Things, tags
Patch by:
fuDescription:
zarhooie explains: "If an entry is tagged nanowrimo or nnwm09, it will show up in the Latest Things by tag feed: http://www.dreamwidth.org/latest?feed=nnwm09 However, if an entry is tagged both nanowrimo AND nnwm09, it will show up twice."
Bug 2660: re-sync CLAs with list
Category: Bugzilla, administrative details
Headbanging by:
deniseDescription: Dreamwidth is a Free/Libre Open Source Software project, and uses contributions from its users. In order to keep things aboveboard and sane, Dreamwidth keeps a Contributor License Agreement on file for everybody who contributes in a way that goes into the open source project. If you're thinking "Hey, wait, everyone who's had a patch accepted has to send/fax/email in a signed statement saying it's OK to put that patch into the FLOSS project? Isn't that a lot of people? Sounds like an administrative nightmare to keep track of!" then you're bang on the nose. This is one of those things that only
denise (or possibly her wife) can do, because she's the one who gets sent the physical paperwork. It has to be re-done every now and then, because more people show up and send in their paperwork. Bug 356: Resubscribing to an inactive subscription results in multiple subscriptions
Category: APIs (RPC, XML, Flat), subscriptions, making things work
Patch by:
kareilaDescription: This is a stupid hairy bug, and I remember having someone (possibly
aveleh, or maybe fu) explain it to me in increasingly smaller words when it was causing problems on LiveJournal. Here's the setup: You subscribe to something (say to new comments on a particular entry that's got a good discussion going). Then you decide you don't want to get notified of this anymore (maybe you're going on vacation and people are chatty), so you unsubscribe. The subscription is not deleted, but inactive. So far, so good. But maybe something makes you want to re-subscribe (you come back from vacation, read the backlog, and prepare for the inbox torrent), and you do so.
Instead of doing the smart thing, finding the existing inactive subscription, and reactivating it, it was creating a second subscription, and then getting massively confused and not allowing edits to the subscription (say you wanted to stop the torrent of emails but still get notification in your inbox). (If you subscribed again, it would create a third duplicate subscription, and so on.) You'd have to completely delete the subscription (of course, it wouldn't allow you to just delete one copy, it hosed all of them) and subscribe again to be able to make it work.
This fixes that: once this goes live the proliferating duplicate uneditable subscriptions will be a thing of the past.
Bug 1958: Remove ToS agreement code
Category: Misc UI/Frontend, making things simpler, fetch the code-machetes
Patch by:
kareila, with initial work by denise. Description: While in theory the ability to make all users agree to the changed Terms of Service every time someone updates it would be useful to some site out there, we don't use it, we don't need it, and out it goes!
Bug 2048: new mood theme: Sina'i Enantia's Dreamy Ds
Category: Misc UI/Frontend, mood themes
Patch by:
kareilaDescription: New mood theme incoming: "Sina'i Enantia's Dreamy Ds", consisting of the stylized 'd' from Dreamwidth's logo, filled in with different colors, patterns, and shadow colors to creatively interpet the various moods, including (perhaps my favorite) a simple black line outline in the shape of the 'd' for the 'blank' mood, and lavender with bright yellow lines crossing, reminiscent of asterisks or fireworks, for 'excited'.
Bug 2659: fix skipped modules in t/00-compile.t
Category: Misc Backend, making testing work properly
Patch by:
kareilaDescription: There were a bunch of things that were skipped in this particular test. This will make things work better and more completely.
Bug 2714: rename userinfo.bml to profile.bml
Category: Misc Backend, updating stuff
Patch by:
ninetydegreesDescription: We don't call it the userinfo anymore, and actually neither does LiveJournal. This primarily helps new, lost developers looking for the file that builds the profile so they can make changes to it. Who'd think to search for "userinfo" if you want to work with "profile"?
Bug 1227: Crossposter fails when cut text attribute contains certain HTML entities
Category: Crossposter, WTF encoding, simple pictures are best
Patch by:
allen, troubleshooting in comments from fu, mark, and jldDescription: Crossposts with various entities in the cut text were failing. There were various forms of trying to figure out how it broke and how best to fix it before
allen declared: "Hey, here's an idea: instead of screwing around with re-encoding the decoded attributes from the parser, and trying to figure out exactly how the decoded – differs from a literal –, how about if we just tell the parser NOT TODECODE THEM IN THE FIRST PLACE? *sigh*" Best idea ever! Very glad to have you developing for us, sir.
Bug 5: Add "current mood of service" toy
Category: silly fun stuff
Patch by:
exor674Description: A silly/fun thing harking back to an old LiveJournal office toy: this takes the moods of recent entries from the Latest Things, ranks them on happy to sad, and displays the averaged mood of the service on the site map and Latest Things page.
Bug 103: Refactor default email change actions
Category: Misc Backend, user email address handling
Patch by:
kareilaDescription: Code for Doing Stuff when someone changed their email address was all over the place, repeated several different times on the back end. It's good to have stuff like this in only one place, so that when stuff changes, it either breaks or it doesn't (rather than one of them breaking and the rest not). Other stuff had started in this direction, and this finishes it.
Bug 1525: privilege function cleanup
Category: Misc Backend, privs
Patch by:
kareilaDescription: FILL IN
Bug 2522: community archive display not updating when alternate posting method used
Category: Misc Backend
Patch by:
kareilaDescription: FILL IN
Bug 2644: User.pm function to count accounts
Category: Misc Backend
Patch by:
kareilaDescription: FILL IN
Bug 2651: remove LJ::get_bio
Category: Misc Backend
Patch by:
kareilaDescription: FILL IN
Bug 2652: Allow LJ::Talk::Post::init to work outside web context
Category: Journal contents
Patch by:
kareilaDescription: FILL IN
Bug 2664: remove LJ::can_manage and LJ::can_manage_other
Category: Misc Backend
Patch by:
kareilaDescription: FILL IN
Bug 2693: LJ::Talk::js_quote_button
Category: Misc Backend
Patch by:
kareilaDescription: FILL IN
Bug 2700: remove LJ::nodb
Category: Misc Backend
Patch by:
kareilaDescription: FILL IN
Bug 715: distinguished collapsed comments from screened/deleted/suspended comments
Category: Style System
Patch by:
ninetydegreesDescription: FILL IN
Bug 2500: Update Funky Circles to use latest CSS3 properties
Category: Style System
Patch by:
ninetydegreesDescription: FILL IN
Bug 2720: /latest?feed=... doesn't work, if the tag_map doesn't contain the group name/feed name
Category: Misc UI/Frontend
Patch by:
fuDescription: FILL IN
Bug 2728: Declaration of which themes are default/should go in the base category, is duplicated
Category: Style System
Patch by:
fuDescription: FILL IN
Bug 2729: Error when loading a journal page which has a list of tags (dev environment only)
Category: Tags
Patch by:
fuDescription: FILL IN
Bug 2730: Using quick reply from a thread in custom comments pages does not return you to thread view
Category: Journal contents
Patch by:
fuDescription: FILL IN